gh-104231: emit warning on __bytes__ and __str__ when returning strict subclass#108814
Open
sunmy2019 wants to merge 2 commits intopython:mainfrom
Open
gh-104231: emit warning on __bytes__ and __str__ when returning strict subclass#108814sunmy2019 wants to merge 2 commits intopython:mainfrom
__bytes__ and __str__ when returning strict subclass#108814sunmy2019 wants to merge 2 commits intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning strict subclasses at
__str__can cause unexpected behavior, since other parts of the VM have always assumedstr(x)to be an instance ofstr, not its strict subclass. The same applies to thebytes(x).Hence, we deprecated the ability to return strict subclasses of
str/bytesat__str__/__bytes__, respectively.__init__onstr(x)/bytes(x)when__new__returns an instance ofstr/bytes' subclass #104231